Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafepointPhaseTest fails in testSafepointStorm #356

Open
smarr opened this issue Jun 16, 2020 · 1 comment · Fixed by #357
Open

SafepointPhaseTest fails in testSafepointStorm #356

smarr opened this issue Jun 16, 2020 · 1 comment · Fixed by #357
Labels
bug Fixes an issue, incorrect implementation

Comments

@smarr
Copy link
Owner

smarr commented Jun 16, 2020

An earlier attempt to investigate the issue lead me to add try/finally around sensitive operations in the ObjectTransitionSafepoint, and I initially thought that would fix it, the test started to pass, but it seems to be failing again: bbdd7b4

Next thing to investigate is whether register/unregister operations play correctly with the assumption of having matching pairs of phases in the phaser.

Current failures look like:

    [junit] junit.framework.AssertionFailedError
     [junit] 	at org.junit.Assert.fail(Assert.java:86)
     [junit] 	at org.junit.Assert.assertTrue(Assert.java:41)
     [junit] 	at org.junit.Assert.assertTrue(Assert.java:52)
     [junit] 	at som.tests.ParallelHelper.executeNTimesInParallel(ParallelHelper.java:56)
     [junit] 	at som.interpreter.objectstorage.SafepointPhaserTest.testSafepointStorm(SafepointPhaserTest.java:93)

It only fails on yuria, not locally.

@smarr smarr added the bug Fixes an issue, incorrect implementation label Jun 16, 2020
@smarr smarr linked a pull request Jun 17, 2020 that will close this issue
@smarr
Copy link
Owner Author

smarr commented Jun 17, 2020

After further investigation, this seemed to be caused by timeouts only and no further issues are currently observed.

I consider it closed with #357 for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes an issue, incorrect implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant