-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC]: add entries
method to array/fixed-endian-factory
#3137
Comments
🚨 Important: PLEASE READ 🚨This issue has been labeled as a good first issue and is available for anyone to work on. If this is your first time contributing to an open source project, some aspects of the development process may seem unusual, arcane, or some combination of both.
Before working on this issue and opening a pull request, please read the project's contributing guidelines. These guidelines and the associated development guide provide important information, including links to stdlib's Code of Conduct, license policy, and steps for setting up your local development environment. To reiterate, we strongly encourage you to refer to our contributing guides before beginning work on this issue. Failure to follow our guidelines significantly decreases the likelihood that you'll successfully contribute to stdlib and may result in automatic closure of a pull request without review. Setting up your local development environment is a critical first step, as doing so ensures that automated development processes for linting, license verification, and unit testing can run prior to authoring commits and pushing changes. If you would prefer to avoid manual setup, we provide pre-configured development containers for use locally or in GitHub Codespaces. We place a high value on consistency throughout the stdlib codebase. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.
In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before beginning work on this issue. ✨ Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. ✨ |
@kgryte i doubt if this method actully require the benchmarks ? also i am not find any in the @stdlib/array/complex128 or @stdlib/array/complex128 ? |
@MeastroZI See https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/array/bool/benchmark/benchmark.entries.js and, while |
@MeastroZI We also have |
Description
This RFC proposes adding support for an
entries
method to@stdlib/array/fixed-endian-factory
.This method is the equivalent of the
TypedArray.prototype.entries
method, but for fixed-endian typed arrays.When adding support, the following tasks should be completed:
./lib/main.js
file should be updated with the added method.To provide a concrete example of what a PR adding the desired method should contain, see 956a462, which is a commit adding
forEach
support. This should provide an idea of what is expected.For an example of specialized typed arrays having customized methods, see
@stdlib/array/bool
@stdlib/array/complex128
@stdlib/array/complex64
While the method proposed in this RFC will likely not match the implementations found in the above packages, those packages should provide a conceptual idea of what is desired. Do not simply copy-paste the code found in those packages.
Notes
Checklist
[RFC]:
.The text was updated successfully, but these errors were encountered: