Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashing Support #2

Closed
clungzta opened this issue Aug 27, 2019 · 19 comments
Closed

Dashing Support #2

clungzta opened this issue Aug 27, 2019 · 19 comments
Assignees
Labels
question Further information is requested

Comments

@clungzta
Copy link

Hi,

I see that this package supports Crystal at this stage.

I did make an attempt at building it on my Dashing system. I successfully got through most of the build steps, until:
colcon build --symlink-install --packages-select stereolabs_zed --cmake-args=-DCMAKE_BUILD_TYPE=Release

Where the following issue occurred:

Starting >>> stereolabs_zed
--- stderr: stereolabs_zed                         
CMake Error at CMakeLists.txt:155 (rclcpp_components_register_nodes):
  Unknown CMake command "rclcpp_components_register_nodes".


---
Failed   <<< stereolabs_zed	[ Exited with code 1 ]

Is Dashing support planned?

Best Regards

@Myzhar Myzhar self-assigned this Aug 27, 2019
@Myzhar Myzhar added the question Further information is requested label Aug 27, 2019
@Myzhar
Copy link
Member

Myzhar commented Aug 27, 2019

Hi @clungzta
Porting the ZED node to Dashing requires a lot of work since it introduced a lot of novelties.
We are working on it and it will be ready soon.

@clungzta
Copy link
Author

Hi

Thank you for the status update and active development.
I look forward to using it upon release.

Best Regards

@estefaniatc
Copy link

Hi,

Is there any update on the expected support for Dashing?

@movingChurch
Copy link

@Myzhar
Hi.

I have a same issue.
Can you tell me when the problem will be solved?

@mhaboali
Copy link

Any updates on the Dashing release?

Thanks!

@cardboardcode
Copy link

@Myzhar Thank you for the ROS2 wrapper of Zed Camera.

Same question as the rest. Any updates on the Dashing or later releases?

@Myzhar
Copy link
Member

Myzhar commented May 4, 2020

We are going to work to release an update for the new ROS2 LTS (Foxy) that will be released in May:
https://index.ros.org/doc/ros2/Releases/Release-Foxy-Fitzroy/

@james-yoo
Copy link

@Myzhar SDK update for the ROS2 Foxy will be compatible Dashing as well?

@Myzhar
Copy link
Member

Myzhar commented May 8, 2020

@james-yoo I must verify what's different between the two versions

@mehmetkillioglu
Copy link

We are going to work to release an update for the new ROS2 LTS (Foxy) that will be released in May:
https://index.ros.org/doc/ros2/Releases/Release-Foxy-Fitzroy/

Hi,

Any updates for Foxy release?

Best,
Mehmet

@Myzhar
Copy link
Member

Myzhar commented Jul 22, 2020

Work in progress
Lot of changes and many quality checks to do.
It will take yet a bit of time before the final release

@annb3
Copy link

annb3 commented Sep 30, 2020

Hi,
Any updates for Dashing release?

Best regards,
Anna

@Myzhar
Copy link
Member

Myzhar commented Sep 30, 2020

No Dashing release, Eloquent release is instead almost ready:
https://github.com/stereolabs/zed-ros2-wrapper/tree/eloquent

@mehmetkillioglu
Copy link

mehmetkillioglu commented Sep 30, 2020

Hi,
Any updates for Dashing release?

Best regards,
Anna

Hi,

From this repository, you can find my custom made version of zed wrapper for Dashing. The tests were not done thoroughly, and I cannot claim it will work fine as I am not affiliated with Stereolabs. I do not accept any liability. Might not be suitable for production-level applications.

Although if you use and find some problems with it, you can create an issue on my repository. I can try to fix it.

Best,
Mehmet

@Myzhar
Copy link
Member

Myzhar commented Sep 30, 2020

FYI the eloquent version of the ZED ROS2 wrapper will not be based on LifeCycle anymore, but it will be based on the "straight" Node model.
This is because the LifeCycle model is not yet totally supported by ROS2 and many packages and nodes like Image Transport and TF do not handle it yet correctly.

@Myzhar
Copy link
Member

Myzhar commented Oct 29, 2020

Eloquent version has been released

@Myzhar Myzhar closed this as completed Oct 29, 2020
@Rayman
Copy link

Rayman commented Mar 16, 2021

@Myzhar can you elaborate a little more about the issues you encountered with LifeCycle? What exactly is not supported? I'm just getting into ROS2 and I thought LifeCycle was a big improvement.

@Myzhar
Copy link
Member

Myzhar commented Mar 16, 2021

Hi @Rayman
Lifecycle is really interesting, but the many important features for us were not available, mainly image_transport and TF broadcasting, but there were problems also with other features.
As far as I know image_transport is not yet available with Lifecycle nodes even with ROS2 Foxy

@Rayman
Copy link

Rayman commented Mar 16, 2021

@Myzhar thank you!

Strange that this is still not supported. I'm linking the issue here for future reference:
ros-perception/image_common#108
ros-perception/image_common#167

@THLL245 THLL245 mentioned this issue Mar 14, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

10 participants