Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another PR can cause a PR to be merged #56

Open
asmeurer opened this issue Mar 3, 2019 · 7 comments
Open

Another PR can cause a PR to be merged #56

asmeurer opened this issue Mar 3, 2019 · 7 comments

Comments

@asmeurer
Copy link
Member

asmeurer commented Mar 3, 2019

See sympy/sympy#9294. A new PR had all the commits from it and was merged. The PR was old and didn't have release notes, resulting in an error from the bot.
@asmeurer
Copy link
Member Author

asmeurer commented Mar 3, 2019

Here's the payload for the webhook for closing that PR:

Headers:

Request URL: https://sympy-bot.herokuapp.com
Request method: POST
content-type: application/json
Expect: 
User-Agent: GitHub-Hookshot/1174c8d
X-GitHub-Delivery: c0ec4b20-3d50-11e9-893d-5c12ccef66dc
X-GitHub-Event: pull_request
X-Hub-Signature: sha1=5bacf19c29e0ff63b2d79873d6b88bd0d8a6a89a

Payload

{
  "action": "closed",
  "number": 9294,
  "pull_request": {
    "url": "https://api.github.com/repos/sympy/sympy/pulls/9294",
    "id": 33208561,
    "node_id": "MDExOlB1bGxSZXF1ZXN0MzMyMDg1NjE=",
    "html_url": "https://github.com/sympy/sympy/pull/9294",
    "diff_url": "https://github.com/sympy/sympy/pull/9294.diff",
    "patch_url": "https://github.com/sympy/sympy/pull/9294.patch",
    "issue_url": "https://api.github.com/repos/sympy/sympy/issues/9294",
    "number": 9294,
    "state": "closed",
    "locked": false,
    "title": "Use new cache for Integer",
    "user": {
      "login": "debugger22",
      "id": 2821646,
      "node_id": "MDQ6VXNlcjI4MjE2NDY=",
      "avatar_url": "https://avatars2.githubusercontent.com/u/2821646?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/debugger22",
      "html_url": "https://github.com/debugger22",
      "followers_url": "https://api.github.com/users/debugger22/followers",
      "following_url": "https://api.github.com/users/debugger22/following{/other_user}",
      "gists_url": "https://api.github.com/users/debugger22/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/debugger22/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/debugger22/subscriptions",
      "organizations_url": "https://api.github.com/users/debugger22/orgs",
      "repos_url": "https://api.github.com/users/debugger22/repos",
      "events_url": "https://api.github.com/users/debugger22/events{/privacy}",
      "received_events_url": "https://api.github.com/users/debugger22/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "See issue https://github.com/sympy/sympy/issues/9292\n",
    "created_at": "2015-04-13T22:06:50Z",
    "updated_at": "2019-03-03T01:07:45Z",
    "closed_at": "2019-03-03T01:07:45Z",
    "merged_at": "2019-03-03T01:07:45Z",
    "merge_commit_sha": "37780644c6c2b20b06e6fc4f7e2e9390011d6e34",
    "assignee": null,
    "assignees": [

    ],
    "requested_reviewers": [

    ],
    "requested_teams": [

    ],
    "labels": [
      {
        "id": 222449974,
        "node_id": "MDU6TGFiZWwyMjI0NDk5NzQ=",
        "url": "https://api.github.com/repos/sympy/sympy/labels/PR:%20author's%20turn",
        "name": "PR: author's turn",
        "color": "ffff80",
        "default": false
      },
      {
        "id": 83720928,
        "node_id": "MDU6TGFiZWw4MzcyMDkyOA==",
        "url": "https://api.github.com/repos/sympy/sympy/labels/core",
        "name": "core",
        "color": "0000FF",
        "default": false
      }
    ],
    "milestone": null,
    "commits_url": "https://api.github.com/repos/sympy/sympy/pulls/9294/commits",
    "review_comments_url": "https://api.github.com/repos/sympy/sympy/pulls/9294/comments",
    "review_comment_url": "https://api.github.com/repos/sympy/sympy/pulls/comments{/number}",
    "comments_url": "https://api.github.com/repos/sympy/sympy/issues/9294/comments",
    "statuses_url": "https://api.github.com/repos/sympy/sympy/statuses/37780644c6c2b20b06e6fc4f7e2e9390011d6e34",
    "head": {
      "label": "debugger22:Integer-new-cache",
      "ref": "Integer-new-cache",
      "sha": "37780644c6c2b20b06e6fc4f7e2e9390011d6e34",
      "user": {
        "login": "debugger22",
        "id": 2821646,
        "node_id": "MDQ6VXNlcjI4MjE2NDY=",
        "avatar_url": "https://avatars2.githubusercontent.com/u/2821646?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/debugger22",
        "html_url": "https://github.com/debugger22",
        "followers_url": "https://api.github.com/users/debugger22/followers",
        "following_url": "https://api.github.com/users/debugger22/following{/other_user}",
        "gists_url": "https://api.github.com/users/debugger22/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/debugger22/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/debugger22/subscriptions",
        "organizations_url": "https://api.github.com/users/debugger22/orgs",
        "repos_url": "https://api.github.com/users/debugger22/repos",
        "events_url": "https://api.github.com/users/debugger22/events{/privacy}",
        "received_events_url": "https://api.github.com/users/debugger22/received_events",
        "type": "User",
        "site_admin": false
      },
      "repo": {
        "id": 17359802,
        "node_id": "MDEwOlJlcG9zaXRvcnkxNzM1OTgwMg==",
        "name": "sympy",
        "full_name": "debugger22/sympy",
        "private": false,
        "owner": {
          "login": "debugger22",
          "id": 2821646,
          "node_id": "MDQ6VXNlcjI4MjE2NDY=",
          "avatar_url": "https://avatars2.githubusercontent.com/u/2821646?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/debugger22",
          "html_url": "https://github.com/debugger22",
          "followers_url": "https://api.github.com/users/debugger22/followers",
          "following_url": "https://api.github.com/users/debugger22/following{/other_user}",
          "gists_url": "https://api.github.com/users/debugger22/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/debugger22/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/debugger22/subscriptions",
          "organizations_url": "https://api.github.com/users/debugger22/orgs",
          "repos_url": "https://api.github.com/users/debugger22/repos",
          "events_url": "https://api.github.com/users/debugger22/events{/privacy}",
          "received_events_url": "https://api.github.com/users/debugger22/received_events",
          "type": "User",
          "site_admin": false
        },
        "html_url": "https://github.com/debugger22/sympy",
        "description": "A computer algebra system written in pure Python",
        "fork": true,
        "url": "https://api.github.com/repos/debugger22/sympy",
        "forks_url": "https://api.github.com/repos/debugger22/sympy/forks",
        "keys_url": "https://api.github.com/repos/debugger22/sympy/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/debugger22/sympy/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/debugger22/sympy/teams",
        "hooks_url": "https://api.github.com/repos/debugger22/sympy/hooks",
        "issue_events_url": "https://api.github.com/repos/debugger22/sympy/issues/events{/number}",
        "events_url": "https://api.github.com/repos/debugger22/sympy/events",
        "assignees_url": "https://api.github.com/repos/debugger22/sympy/assignees{/user}",
        "branches_url": "https://api.github.com/repos/debugger22/sympy/branches{/branch}",
        "tags_url": "https://api.github.com/repos/debugger22/sympy/tags",
        "blobs_url": "https://api.github.com/repos/debugger22/sympy/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/debugger22/sympy/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/debugger22/sympy/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/debugger22/sympy/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/debugger22/sympy/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/debugger22/sympy/languages",
        "stargazers_url": "https://api.github.com/repos/debugger22/sympy/stargazers",
        "contributors_url": "https://api.github.com/repos/debugger22/sympy/contributors",
        "subscribers_url": "https://api.github.com/repos/debugger22/sympy/subscribers",
        "subscription_url": "https://api.github.com/repos/debugger22/sympy/subscription",
        "commits_url": "https://api.github.com/repos/debugger22/sympy/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/debugger22/sympy/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/debugger22/sympy/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/debugger22/sympy/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/debugger22/sympy/contents/{+path}",
        "compare_url": "https://api.github.com/repos/debugger22/sympy/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/debugger22/sympy/merges",
        "archive_url": "https://api.github.com/repos/debugger22/sympy/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/debugger22/sympy/downloads",
        "issues_url": "https://api.github.com/repos/debugger22/sympy/issues{/number}",
        "pulls_url": "https://api.github.com/repos/debugger22/sympy/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/debugger22/sympy/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/debugger22/sympy/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/debugger22/sympy/labels{/name}",
        "releases_url": "https://api.github.com/repos/debugger22/sympy/releases{/id}",
        "deployments_url": "https://api.github.com/repos/debugger22/sympy/deployments",
        "created_at": "2014-03-03T08:33:45Z",
        "updated_at": "2015-04-23T02:12:12Z",
        "pushed_at": "2017-03-20T14:22:39Z",
        "git_url": "git://github.com/debugger22/sympy.git",
        "ssh_url": "[email protected]:debugger22/sympy.git",
        "clone_url": "https://github.com/debugger22/sympy.git",
        "svn_url": "https://github.com/debugger22/sympy",
        "homepage": "http://sympy.org/",
        "size": 69853,
        "stargazers_count": 0,
        "watchers_count": 0,
        "language": "Python",
        "has_issues": false,
        "has_projects": true,
        "has_downloads": true,
        "has_wiki": true,
        "has_pages": false,
        "forks_count": 0,
        "mirror_url": null,
        "archived": false,
        "open_issues_count": 0,
        "license": {
          "key": "other",
          "name": "Other",
          "spdx_id": "NOASSERTION",
          "url": null,
          "node_id": "MDc6TGljZW5zZTA="
        },
        "forks": 0,
        "open_issues": 0,
        "watchers": 0,
        "default_branch": "master"
      }
    },
    "base": {
      "label": "sympy:master",
      "ref": "master",
      "sha": "feb65e4e9d6a01a831cddb2ebe8fb560496efb36",
      "user": {
        "login": "sympy",
        "id": 260832,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==",
        "avatar_url": "https://avatars1.githubusercontent.com/u/260832?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/sympy",
        "html_url": "https://github.com/sympy",
        "followers_url": "https://api.github.com/users/sympy/followers",
        "following_url": "https://api.github.com/users/sympy/following{/other_user}",
        "gists_url": "https://api.github.com/users/sympy/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/sympy/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/sympy/subscriptions",
        "organizations_url": "https://api.github.com/users/sympy/orgs",
        "repos_url": "https://api.github.com/users/sympy/repos",
        "events_url": "https://api.github.com/users/sympy/events{/privacy}",
        "received_events_url": "https://api.github.com/users/sympy/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "repo": {
        "id": 640534,
        "node_id": "MDEwOlJlcG9zaXRvcnk2NDA1MzQ=",
        "name": "sympy",
        "full_name": "sympy/sympy",
        "private": false,
        "owner": {
          "login": "sympy",
          "id": 260832,
          "node_id": "MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==",
          "avatar_url": "https://avatars1.githubusercontent.com/u/260832?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/sympy",
          "html_url": "https://github.com/sympy",
          "followers_url": "https://api.github.com/users/sympy/followers",
          "following_url": "https://api.github.com/users/sympy/following{/other_user}",
          "gists_url": "https://api.github.com/users/sympy/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/sympy/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/sympy/subscriptions",
          "organizations_url": "https://api.github.com/users/sympy/orgs",
          "repos_url": "https://api.github.com/users/sympy/repos",
          "events_url": "https://api.github.com/users/sympy/events{/privacy}",
          "received_events_url": "https://api.github.com/users/sympy/received_events",
          "type": "Organization",
          "site_admin": false
        },
        "html_url": "https://github.com/sympy/sympy",
        "description": "A computer algebra system written in pure Python",
        "fork": false,
        "url": "https://api.github.com/repos/sympy/sympy",
        "forks_url": "https://api.github.com/repos/sympy/sympy/forks",
        "keys_url": "https://api.github.com/repos/sympy/sympy/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/sympy/sympy/teams",
        "hooks_url": "https://api.github.com/repos/sympy/sympy/hooks",
        "issue_events_url": "https://api.github.com/repos/sympy/sympy/issues/events{/number}",
        "events_url": "https://api.github.com/repos/sympy/sympy/events",
        "assignees_url": "https://api.github.com/repos/sympy/sympy/assignees{/user}",
        "branches_url": "https://api.github.com/repos/sympy/sympy/branches{/branch}",
        "tags_url": "https://api.github.com/repos/sympy/sympy/tags",
        "blobs_url": "https://api.github.com/repos/sympy/sympy/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/sympy/sympy/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/sympy/sympy/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/sympy/sympy/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/sympy/sympy/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/sympy/sympy/languages",
        "stargazers_url": "https://api.github.com/repos/sympy/sympy/stargazers",
        "contributors_url": "https://api.github.com/repos/sympy/sympy/contributors",
        "subscribers_url": "https://api.github.com/repos/sympy/sympy/subscribers",
        "subscription_url": "https://api.github.com/repos/sympy/sympy/subscription",
        "commits_url": "https://api.github.com/repos/sympy/sympy/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/sympy/sympy/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/sympy/sympy/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/sympy/sympy/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/sympy/sympy/contents/{+path}",
        "compare_url": "https://api.github.com/repos/sympy/sympy/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/sympy/sympy/merges",
        "archive_url": "https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/sympy/sympy/downloads",
        "issues_url": "https://api.github.com/repos/sympy/sympy/issues{/number}",
        "pulls_url": "https://api.github.com/repos/sympy/sympy/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/sympy/sympy/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/sympy/sympy/labels{/name}",
        "releases_url": "https://api.github.com/repos/sympy/sympy/releases{/id}",
        "deployments_url": "https://api.github.com/repos/sympy/sympy/deployments",
        "created_at": "2010-04-30T20:37:14Z",
        "updated_at": "2019-03-03T00:44:14Z",
        "pushed_at": "2019-03-03T01:07:24Z",
        "git_url": "git://github.com/sympy/sympy.git",
        "ssh_url": "[email protected]:sympy/sympy.git",
        "clone_url": "https://github.com/sympy/sympy.git",
        "svn_url": "https://github.com/sympy/sympy",
        "homepage": "https://sympy.org/",
        "size": 100615,
        "stargazers_count": 5600,
        "watchers_count": 5600,
        "language": "Python",
        "has_issues": true,
        "has_projects": true,
        "has_downloads": true,
        "has_wiki": true,
        "has_pages": false,
        "forks_count": 2525,
        "mirror_url": null,
        "archived": false,
        "open_issues_count": 3562,
        "license": {
          "key": "other",
          "name": "Other",
          "spdx_id": "NOASSERTION",
          "url": null,
          "node_id": "MDc6TGljZW5zZTA="
        },
        "forks": 2525,
        "open_issues": 3562,
        "watchers": 5600,
        "default_branch": "master"
      }
    },
    "_links": {
      "self": {
        "href": "https://api.github.com/repos/sympy/sympy/pulls/9294"
      },
      "html": {
        "href": "https://github.com/sympy/sympy/pull/9294"
      },
      "issue": {
        "href": "https://api.github.com/repos/sympy/sympy/issues/9294"
      },
      "comments": {
        "href": "https://api.github.com/repos/sympy/sympy/issues/9294/comments"
      },
      "review_comments": {
        "href": "https://api.github.com/repos/sympy/sympy/pulls/9294/comments"
      },
      "review_comment": {
        "href": "https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"
      },
      "commits": {
        "href": "https://api.github.com/repos/sympy/sympy/pulls/9294/commits"
      },
      "statuses": {
        "href": "https://api.github.com/repos/sympy/sympy/statuses/37780644c6c2b20b06e6fc4f7e2e9390011d6e34"
      }
    },
    "author_association": "MEMBER",
    "draft": false,
    "merged": true,
    "mergeable": null,
    "rebaseable": null,
    "mergeable_state": "unknown",
    "merged_by": {
      "login": "oscarbenjamin",
      "id": 1159732,
      "node_id": "MDQ6VXNlcjExNTk3MzI=",
      "avatar_url": "https://avatars1.githubusercontent.com/u/1159732?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/oscarbenjamin",
      "html_url": "https://github.com/oscarbenjamin",
      "followers_url": "https://api.github.com/users/oscarbenjamin/followers",
      "following_url": "https://api.github.com/users/oscarbenjamin/following{/other_user}",
      "gists_url": "https://api.github.com/users/oscarbenjamin/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/oscarbenjamin/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/oscarbenjamin/subscriptions",
      "organizations_url": "https://api.github.com/users/oscarbenjamin/orgs",
      "repos_url": "https://api.github.com/users/oscarbenjamin/repos",
      "events_url": "https://api.github.com/users/oscarbenjamin/events{/privacy}",
      "received_events_url": "https://api.github.com/users/oscarbenjamin/received_events",
      "type": "User",
      "site_admin": false
    },
    "comments": 23,
    "review_comments": 2,
    "maintainer_can_modify": false,
    "commits": 6,
    "additions": 13,
    "deletions": 98,
    "changed_files": 2
  },
  "repository": {
    "id": 640534,
    "node_id": "MDEwOlJlcG9zaXRvcnk2NDA1MzQ=",
    "name": "sympy",
    "full_name": "sympy/sympy",
    "private": false,
    "owner": {
      "login": "sympy",
      "id": 260832,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/260832?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/sympy",
      "html_url": "https://github.com/sympy",
      "followers_url": "https://api.github.com/users/sympy/followers",
      "following_url": "https://api.github.com/users/sympy/following{/other_user}",
      "gists_url": "https://api.github.com/users/sympy/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/sympy/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/sympy/subscriptions",
      "organizations_url": "https://api.github.com/users/sympy/orgs",
      "repos_url": "https://api.github.com/users/sympy/repos",
      "events_url": "https://api.github.com/users/sympy/events{/privacy}",
      "received_events_url": "https://api.github.com/users/sympy/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/sympy/sympy",
    "description": "A computer algebra system written in pure Python",
    "fork": false,
    "url": "https://api.github.com/repos/sympy/sympy",
    "forks_url": "https://api.github.com/repos/sympy/sympy/forks",
    "keys_url": "https://api.github.com/repos/sympy/sympy/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/sympy/sympy/teams",
    "hooks_url": "https://api.github.com/repos/sympy/sympy/hooks",
    "issue_events_url": "https://api.github.com/repos/sympy/sympy/issues/events{/number}",
    "events_url": "https://api.github.com/repos/sympy/sympy/events",
    "assignees_url": "https://api.github.com/repos/sympy/sympy/assignees{/user}",
    "branches_url": "https://api.github.com/repos/sympy/sympy/branches{/branch}",
    "tags_url": "https://api.github.com/repos/sympy/sympy/tags",
    "blobs_url": "https://api.github.com/repos/sympy/sympy/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/sympy/sympy/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/sympy/sympy/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/sympy/sympy/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/sympy/sympy/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/sympy/sympy/languages",
    "stargazers_url": "https://api.github.com/repos/sympy/sympy/stargazers",
    "contributors_url": "https://api.github.com/repos/sympy/sympy/contributors",
    "subscribers_url": "https://api.github.com/repos/sympy/sympy/subscribers",
    "subscription_url": "https://api.github.com/repos/sympy/sympy/subscription",
    "commits_url": "https://api.github.com/repos/sympy/sympy/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/sympy/sympy/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/sympy/sympy/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/sympy/sympy/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/sympy/sympy/contents/{+path}",
    "compare_url": "https://api.github.com/repos/sympy/sympy/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/sympy/sympy/merges",
    "archive_url": "https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/sympy/sympy/downloads",
    "issues_url": "https://api.github.com/repos/sympy/sympy/issues{/number}",
    "pulls_url": "https://api.github.com/repos/sympy/sympy/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/sympy/sympy/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/sympy/sympy/labels{/name}",
    "releases_url": "https://api.github.com/repos/sympy/sympy/releases{/id}",
    "deployments_url": "https://api.github.com/repos/sympy/sympy/deployments",
    "created_at": "2010-04-30T20:37:14Z",
    "updated_at": "2019-03-03T00:44:14Z",
    "pushed_at": "2019-03-03T01:07:24Z",
    "git_url": "git://github.com/sympy/sympy.git",
    "ssh_url": "[email protected]:sympy/sympy.git",
    "clone_url": "https://github.com/sympy/sympy.git",
    "svn_url": "https://github.com/sympy/sympy",
    "homepage": "https://sympy.org/",
    "size": 100615,
    "stargazers_count": 5600,
    "watchers_count": 5600,
    "language": "Python",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": true,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 2525,
    "mirror_url": null,
    "archived": false,
    "open_issues_count": 3562,
    "license": {
      "key": "other",
      "name": "Other",
      "spdx_id": "NOASSERTION",
      "url": null,
      "node_id": "MDc6TGljZW5zZTA="
    },
    "forks": 2525,
    "open_issues": 3562,
    "watchers": 5600,
    "default_branch": "master"
  },
  "organization": {
    "login": "sympy",
    "id": 260832,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==",
    "url": "https://api.github.com/orgs/sympy",
    "repos_url": "https://api.github.com/orgs/sympy/repos",
    "events_url": "https://api.github.com/orgs/sympy/events",
    "hooks_url": "https://api.github.com/orgs/sympy/hooks",
    "issues_url": "https://api.github.com/orgs/sympy/issues",
    "members_url": "https://api.github.com/orgs/sympy/members{/member}",
    "public_members_url": "https://api.github.com/orgs/sympy/public_members{/member}",
    "avatar_url": "https://avatars1.githubusercontent.com/u/260832?v=4",
    "description": "Symbolic manipulation in Python."
  },
  "sender": {
    "login": "oscarbenjamin",
    "id": 1159732,
    "node_id": "MDQ6VXNlcjExNTk3MzI=",
    "avatar_url": "https://avatars1.githubusercontent.com/u/1159732?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/oscarbenjamin",
    "html_url": "https://github.com/oscarbenjamin",
    "followers_url": "https://api.github.com/users/oscarbenjamin/followers",
    "following_url": "https://api.github.com/users/oscarbenjamin/following{/other_user}",
    "gists_url": "https://api.github.com/users/oscarbenjamin/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/oscarbenjamin/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/oscarbenjamin/subscriptions",
    "organizations_url": "https://api.github.com/users/oscarbenjamin/orgs",
    "repos_url": "https://api.github.com/users/oscarbenjamin/repos",
    "events_url": "https://api.github.com/users/oscarbenjamin/events{/privacy}",
    "received_events_url": "https://api.github.com/users/oscarbenjamin/received_events",
    "type": "User",
    "site_admin": false
  }
}

@asmeurer
Copy link
Member Author

asmeurer commented Mar 3, 2019

I guess the way you can tell is that the merge_commit_sha is the same as the head commit (usually it's a new merge commit). This isn't documented here, however.

@asmeurer
Copy link
Member Author

asmeurer commented Mar 3, 2019

I sent a message to GitHub support asking to confirm that this is indeed the correct way to detect this.

@asmeurer
Copy link
Member Author

asmeurer commented Mar 5, 2019

I'm actually unsure what the bot behavior here should be. Perhaps in situations where a PR is merged via another PR, you would expect the bot to add the notes from both PRs.

Can anyone suggest what behavior they would expect from the bot when a PR is continued in another PR then automerged when the continuation PR is merged, such as sympy/sympy#9294?

@oscargus
Copy link

So, if there were valid release notes in sympy/sympy#9294 both would be added?

Probably the "simple" solution is to close PRs which are continued elsewhere. There may be some issues if one just picks a few few of the commits, but that should be a rather rare case...

@asmeurer
Copy link
Member Author

asmeurer commented Mar 31, 2019 •
edited
Loading

Right now both would be added. That's why the bot failed with 🚨. The bot tried to add the release notes, but they didn't exist.

The proposal here was to make the auto-closed one not be added. But I'm not sure which behavior is better.

@oscargus
Copy link

Given that the author finalizing the PR should provide valid release notes, I believe that not taking the ones from the auto-closed would be the preferred behavior. The alternative is that the person finalizing it does a "NO ENTRY" and does not get any credits in the release notes. Which I think will meet some resistance... (There is of course also the option that more features are added, but I think just as often someone just wraps up a previous stalled PR.)

So my 2 cents goes to not adding for the auto-closed.

@asmeurer asmeurer mentioned this issue Nov 11, 2019
Merged
@asmeurer asmeurer mentioned this issue Jan 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asmeurer @oscargus