Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unsigned char in buffer #105

Open
drewdzzz opened this issue Nov 22, 2024 · 0 comments
Open

Support unsigned char in buffer #105

drewdzzz opened this issue Nov 22, 2024 · 0 comments

Comments

@drewdzzz
Copy link
Collaborator

drewdzzz commented Nov 22, 2024

While writing an example of working with raw data, I faced an interesting problem. I tried pack an empty MsgPack array manually (char data[] = {0x90};) but compiler suggested me to use unsigned char instead. It seemed to be a good idea but when I passed the result to the encoder, it failed to write to the buffer - the problem is encoder uses WData, which is, actually, a char * (the same story with RData, by the way), so compiler failed to find an appropriate overload of Buffer::write. We should inspect places using char * and fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant