Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows support #13

Closed
wants to merge 1 commit into from
Closed

Add windows support #13

wants to merge 1 commit into from

Conversation

frostming
Copy link

@frostming frostming commented Apr 4, 2019 •
edited
Loading

  1. Add virtualenv to install requires
  2. Change the virtualenv activating logic to be compatible with Windows.

Fixes #12

@frostming
Copy link
Author

Maybe we should add some CI tests to make sure it is working for a project with 400+ stars.

Bobronium
Bobronium reviewed May 23, 2022
View reviewed changes
trypackage/core.py
command, retcode, context.logfile))


def inline_activate_virtualenv(virtualenv):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks scary

@frostming frostming closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobronium Bobronium Bobronium left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'.' is not recognized as an internal or external command, operable program or batch file.
2 participants
@frostming @Bobronium