Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-s3: upload-success fired without s3Multipart set #5513

Open
2 tasks done
fschwahn opened this issue Nov 14, 2024 · 3 comments
Open
2 tasks done

aws-s3: upload-success fired without s3Multipart set #5513

fschwahn opened this issue Nov 14, 2024 · 3 comments
Labels

Comments

@fschwahn
Copy link

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

I'm using uppy as follows:

    this.uppy = new Uppy(uppyOptions);
    this.uppy.use(DragDrop, { target: el });
    this.uppy.use(AwsS3, {
      endpoint: "/",
      headers: options.companionHeaders || {},
      shouldUseMultipart: true,
    });

Sometimes, the upload-success-callback is called, but file.s3Multipart is not set.

I wasn't able to reproduce myself, but it happens regularly (ie. once / twice per day) in production. I added some logging to the upload-success-callback, and this is passed in as file into upload-success:

{
    "data":
    {
        "relativePath": null
    },
    "extension": "mov",
    "id": "FileUploader7-spielszene/1/mov-10-2v-10-1e-video/quicktime-56090352-1731593973000",
    "isGhost": false,
    "isRemote": false,
    "meta":
    {
        "name": "Spielszene 1.mov",
        "relativePath": null,
        "type": "video/quicktime"
    },
    "name": "Spielszene 1.mov",
    "progress":
    {
        "bytesTotal": 56090352,
        "bytesUploaded": 56090352,
        "percentage": 100,
        "uploadComplete": false,
        "uploadStarted": null
    },
    "size": 56090352,
    "source": "DragDrop",
    "type": "video/quicktime"
}

It can be seen that s3Multipart is completely missing from the file-object.

Expected behavior

When upload-success is invoked s3Multipart should always be set.

Actual behavior

file.s3Multipart is missing.

@fschwahn fschwahn added the Bug label Nov 14, 2024
@Murderlon
Copy link
Member

Hi, without a way to reproduce this I'm not sure how this issue can become actionable and therefor be closed.

@fschwahn
Copy link
Author

I know this is not much to go on, but could you give me hints how I can debug this? This is happening a few times per day (out of 100s of uploads), and I'm not sure how this callback gets invoked without s3Multipart set, or what I could do wrong in my integration to force cause such a behavior.

@Murderlon
Copy link
Member

I'll try to take a look if I can spot something when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants