Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too fast emails? #32

Open
AlexWayfer opened this issue May 15, 2018 · 8 comments
Open

Too fast emails? #32

AlexWayfer opened this issue May 15, 2018 · 8 comments

Comments

@AlexWayfer
Copy link

Hello!

Some releases emailed too fast, I think, and emails have no release description.

Examples:

Babel

3:21 AM

image

11:09 AM

screenshot-inbox google com-2018 05 15-11-34-01

Autoprefixer (May 13)

11:20 AM

image

4:12 PM

image

@vfeskov
Copy link
Owner

vfeskov commented May 15, 2018

so this is what Sibbell calls realtime, interesting

i can add a checkbox to let you control if you wanna wait for release description or you want email ASAP.

i probably cannot determine automatically if release description will follow, because some repos simply don't have release descriptions at all, e.g. https://github.com/angular/angular/releases

@AlexWayfer
Copy link
Author

i probably cannot determine automatically if release description will follow, because some repos simply don't have release descriptions at all, e.g. https://github.com/angular/angular/releases

Yes, I know.

i can add a checkbox to let you control if you wanna wait for release description or you want email ASAP.

Good thought. I think, there can be delay for 30 minutes or even 2 hours. Maybe some delay by default.

Real-time is cool, but I'm not sure that this is better than email this release description.

@vfeskov
Copy link
Owner

vfeskov commented May 15, 2018

some people do want the emails ASAP tho, e.g. #13

@AlexWayfer
Copy link
Author

some people do want the emails ASAP tho, e.g. #13

They can enable real-time, I'm talking just about default. But as you wish.

@Jacalz
Copy link

Jacalz commented May 24, 2018

+1 from me on this one, having a setting for it to wait for the description would be very useful 👍

@kireerik
Copy link

i probably cannot determine automatically if release description will follow, because some repos simply don't have release descriptions at all, e.g. https://github.com/angular/angular/releases

This means you can check this. So if a repository doesn't have at least one release with a release description, then you can send the email instantly even if this option is enabled. If it does have at least one release with a release description then you can probably use a delay as previously mentioned if this option is enabled.

Also extracting details form the repository's CHANGELOG.md could be useful in this case. For example: https://github.com/angular/angular/blob/master/CHANGELOG.md

@AlexWayfer
Copy link
Author

Also extracting details form the repository's CHANGELOG.md could be useful in this case. For example: https://github.com/angular/angular/blob/master/CHANGELOG.md

This is my dream for service like GitPunch, but I think it's very difficult (too many formats, too many regexps).

@Jacalz
Copy link

Jacalz commented Jul 4, 2018

A simple way would be to just have an option to delay the emails by a set amount or something...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants