Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Leverage/Collaborate with Karaoke Nerds #310

Open
Deastrom opened this issue Jan 1, 2024 · 3 comments
Open

[FEATURE] Leverage/Collaborate with Karaoke Nerds #310

Deastrom opened this issue Jan 1, 2024 · 3 comments

Comments

@Deastrom
Copy link

Deastrom commented Jan 1, 2024

Is your feature request related to a problem? Please describe.
There is a little bit of frustration with the wide open + "karaoke" youtube search and finding quality karaoke videos.

Describe the solution you'd like
https://www.karaokenerds.com/About/

Karaoke Nerds has some functionality that could greatly improve the video search experience in the application. A strong integration could also lead to leveraging Karaoke Nerds user experience features as well, allowing pikaraoke to focus on downloading and queuing up songs.

Describe alternatives you've considered
I've already kind of gone down this rabbit hole but the code for karaoke nerds isn't open source AND it's not leveraging any kind of backend api. So this integration would likely be more like web parsing, which isn't ideal.

I don't know if it's possible to iframe karaokenerds and add a "download and add to queue" or "add to queue"(if already downloaded) button in the iframe (i don't front end much, or at all)

Additional context
Love the project. Used it at my new years eve party last night with the latest improvements. Keep up the good work.

@RecursiveFunctions
Copy link

I and a few others have considered it. I'll work on it in a separate branch. Not sure how I'd go about it though. Might need to use a scraper as suggested. Maybe have a manual 'update' button on the settings webpage for it too.

One thing to keep in mind is that karaoke nerds is not all-inclusive of all the karaoke videos on youtube. It doesn't include midi vids, and it's not always up to date, and some channels like sing king are not included.

@Deastrom
Copy link
Author

Yeah, the crux of the problem is video/karaoke quality. I suppose I'd be really happy with a "priority channels" list or something like that. But I know that'd make the youtube search more complicated.

@Deastrom
Copy link
Author

Deastrom commented Feb 4, 2024

I and a few others have considered it. I'll work on it in a separate branch. Not sure how I'd go about it though. Might need to use a scraper as suggested. Maybe have a manual 'update' button on the settings webpage for it too.

One thing to keep in mind is that karaoke nerds is not all-inclusive of all the karaoke videos on youtube. It doesn't include midi vids, and it's not always up to date, and some channels like sing king are not included.

Also, if you DM him in discord, i'm sure he'd work with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants