Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close_milestone action should be more forgiving when a milestone is already closed #568

Open
iangmaia opened this issue Jun 6, 2024 · 0 comments

Comments

@iangmaia
Copy link
Contributor

iangmaia commented Jun 6, 2024

In the CloseMilestoneAction, we first fetch the milestone to be able to close it, throwing an error if the milestone is nil:

milestone = github_helper.get_milestone(repository, milestone_title)
UI.user_error!("Milestone #{milestone_title} not found.") if milestone.nil?

The problem with that is a situation seen a couple of times during release management: closed milestones aren't returned by github_helper.get_milestone.

We should either stop raising this error completely or find a way in the API to get a milestone even when closed, so that at least we would avoid raising the error in such cases and the action becomes a no-op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant