Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes without TYPEFLAG_FCANCREATE are omitted #35

Open
DaveInCaz opened this issue Jan 19, 2023 · 2 comments
Open

Classes without TYPEFLAG_FCANCREATE are omitted #35

DaveInCaz opened this issue Jan 19, 2023 · 2 comments

Comments

@DaveInCaz
Copy link
Contributor

I noticed the following line in pvDumpClasses():

If .AttributeMask And (TYPEFLAG_FCANCREATE Or TYPEFLAG_FCONTROL) <> 0 Then
...

So if either of those flags are NOT set, the class is NOT output.

What was the reason to omit classes without these flags? It seems like this means PublicNotCreatable classes are left out, for instance.

Thanks

@wqweto
Copy link
Owner

wqweto commented Jan 19, 2023

This looks completely wrong. It’s missing parentheses around bitwise And effectively making it always succeed. Ouch!

@wqweto
Copy link
Owner

wqweto commented Jan 20, 2023

Btw, this branch is reached only when the OCX/DLL is not registered and it's actually problematic to extract complete manifest info from component's typelib only so this is not recommended and is an unsupported use-case.

The point is for UMMM to work correctly, source OCX/DLL components have to be registered on the machine the manifest is created at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants