Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication Client: Use PagingInfo correctly #1299

Open
Tracked by #118
mkysel opened this issue Nov 20, 2024 · 0 comments
Open
Tracked by #118

Replication Client: Use PagingInfo correctly #1299

mkysel opened this issue Nov 20, 2024 · 0 comments

Comments

@mkysel
Copy link
Contributor

mkysel commented Nov 20, 2024

          As a note - the `PagingInfo` of the `QueryGroupMessagesRequest` has an `id_cursor` that we could potentially convert into vector clock format here as a short-term hack. Unsure if we get subtle bugs without this, as the client expects to query from where it left off in the queue. In the long-term we need to do a bigger refactor to properly support vector clocks though, just making a note in case you run into bugs in the meantime

Originally posted by @richardhuaaa in #1214 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant