Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid port * after host #48

Open
omani opened this issue Oct 17, 2019 · 3 comments · May be fixed by #50
Open

Invalid port * after host #48

omani opened this issue Oct 17, 2019 · 3 comments · May be fixed by #50

Comments

@omani
Copy link

omani commented Oct 17, 2019

hi there,
with the new golang version (and its built in url lib):

if !n.bound {
		_, n.port, err = bind(n.inbox, "tcp://*:*")
		if err != nil {
			return err
		}
		n.bound = true
	}

in node.go does not work anymore.

my workaround was to say:

if !n.bound {
		_, n.port, err = bind(n.inbox, "tcp://*:0")
		if err != nil {
			return err
		}
		n.bound = true
	}

in node.go

and:

	if p == "0" {
...

in node.go later. instead of if p == "*".

fyi.

@omani omani changed the title Invalid signature Invalid port * after host Oct 17, 2019
@aeroblue
Copy link

I had the same issue and the changes suggested by @omani fixes it. According to the net/url docs:

validOptionalPort reports whether port is either an empty string or matches /^:\d*$/

@omani can you do a pull request or should I?

@omani
Copy link
Author

omani commented Nov 15, 2019

yeah will do.

@omani omani linked a pull request Jan 24, 2020 that will close this issue
@omani
Copy link
Author

omani commented Jan 24, 2020

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants