Fix #263: Implement log rotation for server/error logs in docker-zulip #473
Conversation
| supervisorctl reopen-logs | ||
| endscript | ||
| } | ||
| EOF |
There was a problem hiding this comment.
Zulip ships with a logrotate configuration file; I don't think we should need to provide this in the container image as well, as zulip itself should have installed it already. Would be good to avoid duplicating, as the copy here will get stale.
| RUN apt-get update && apt-get install -y \ | ||
| logrotate \ | ||
| cron \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
We install dependencies via puppet, you shouldn't need to add anything here. I expect these files are already present, and the actual bug is needing to actually run logrotate via supervisord (like how we do cron), since it likely is installed but not running.
|
@timabbott Sir, I would like to make another attempt at resolving this issue. Kindly assign it to me once again. Additionally, I seek your guidance in solving the problem and improving my solution. Please provide suggestions on how I can refine my approach. I am confident that I can resolve this issue successfully. |
This PR implements proper log rotation for server and error logs in docker-zulip.
Changes made:
Testing:
Fixes #263