Use Active Storage for Picture and File attachments #2968
Commits on Nov 27, 2024
-
-
Add dragonfly to image processing converter
ActiveStorage uses the image_processing gem to process images. This uses a hash to describe the conversion instead of a string
-
-
-
-
Use custom validations for picture size and format
Instead of using the Dragonfly Model validations we write our own. That way we can use another image attachment library more easily
-
-
Do not sharpen images by default
The vips image_processing processor sharpens images by default. This disables this behavior.
-
-
Delegate convertible format check to activestorage
Active storage already knows if a file is convertible
-
Eager load attachments in admin pictures controller
This avoids N+1 in the image library
-
Delegate image_file_* methods to attached file
Using activestorage methods to read the values. Ideally we would cache these values, but active storage asynchronously sets these values and provides no callback we could use.
-
Remove custom picture variant classes
Now that we use ActiveStorage we can remove our custom picture variant handling
-
Move can_be_cropped_to? into picture_thumbnails
This method is the only one left after the PictureVariant and PictureThumb removal.
-
-
-
Use file mime type for picture by format select
Active storage has the mime type stored not the extension.
-
-
ruby-vips and mini_magick need to be told to ignore the page in order to resize animated gifs.
-
Before we where not telling active storage that we want a certain format explicitely. We need that for displaying animated PNGs properly.
-
-
-
Use image_file_extension as original format
ActiveStorage expects an extension and not an mime type.
-
Allow webp as image format for ActiveStorage
It is only configured by default in unreleased Rails 7.2
-
