-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Camera: runcam backend #26887
base: master
Are you sure you want to change the base?
AP_Camera: runcam backend #26887
Conversation
I like where this is going! |
@andyp1per where are you going with this one? What advantages were you seeing from being a camera backend? I'd note that the camera library, even in its most compact form is still going to be pretty chunky, and recent commits have shown we don't really care about keeping it absolutely tight space-wise. Definitely not saying it's a bad idea! |
6eb3394
to
302a30b
Compare
The main thing is to get the mavlink and other support for free. People keep asking for runcam mission support |
2dcb5eb
to
3a267a9
Compare
ea11a70
to
bfb7c81
Compare
fbb728c
to
098da39
Compare
@rmackay9 this is ready to go - any chance of a review? |
PeterB's requests have been addressed it seems
@@ -193,6 +209,8 @@ void AP_Camera::init() | |||
return; | |||
} | |||
|
|||
memset(_backends, 0, sizeof(void*)*AP_CAMERA_MAX_INSTANCES); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being done?!
memset(_backends, 0, sizeof(void*)*AP_CAMERA_MAX_INSTANCES); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the array is not zeroed and we check whether the backend has been allocated.
RunCam parameter conversion add RunCam camera settings and control
f357ac4
to
dace135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could rename the class to be AP_Camera_RunCam but I don't think we should slow-walk this any more. It's an improvement and it's the beginning of the 4.7 dev cycle so looks OK to me, thanks!
RunCam as a proper camera backend.
Adds a couple of the mavlink info callbacks
Parameter conversion and operation verified on my RunCam split