Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for liquidprompt theme v2.0 support #2203

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdoenges
Copy link

@cdoenges cdoenges commented Apr 1, 2023

When using the theme liquidprompt v2.0 or later with bash-it, bash issues an error message when the prompt is displayed with the current working directory in a git repository that is not in detached head state.

Description

In v2.0 (released Feb 5, 2021) of liquidprompt, the function _lp_escape() was renamed to __lp_escape(). Therefore, calling the function by the old name results in an error message from bash. By using the new name, the problem goes away.

The shim used by bash-it still uses the old name.

Motivation and Context

The annoying error message goes away with this change.

How Has This Been Tested?

Change made. Issued bash-it reload. Error message no longer appears.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

In v2.0 (the current version) of liquidprompt, the function `_lp_escape()` was renamed to `__lp_escape()`.
@davidpfarrell
Copy link
Contributor

Greetings @cdoenges !

I'm guessing you didn't see #2175 which is also trying to fix this.

Maybe you can collab with @DarrenBishop to review each other's changes and decide on the best way forward.

@seefood seefood marked this pull request as draft November 6, 2024 15:08
@seefood
Copy link
Contributor

seefood commented Nov 6, 2024

please see the conflict with master and decide if this still relevant?

@seefood seefood added seems abandoned rattle the cage, and close if nobody wants to keep it going waiting-for-response labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seems abandoned rattle the cage, and close if nobody wants to keep it going waiting-for-response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants