Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 665 #687

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Issue 665 #687

wants to merge 5 commits into from

Commits on Aug 30, 2018

  1. Fix 665: SpanLabelView may not enforce non-overlap constraint

    - Changed SpanLabelView.addConstituent(Constituent) to enforce nonoverlapping
      constituents when appropriate, i.e. the flag is set.
    - Added a class with two basic tests to make sure that the changes work
      correctly.
    ChaseDuncan committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    01bee8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a88173d View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Addressing comments

    - Moved inline comment into JavaDoc comment above class in SpanLabelViewTest
    - Moved start, end variable initialization and overlap into conditional
      statement so that they only occur when overlapping spans are not allowed
    - Moved SpanLevelViewTest into correct module
    ChaseDuncan committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    01e8bd4 View commit details
    Browse the repository at this point in the history
  2. Fixing TeamCity errors

    - Fixed multiple places in MD and one place in corpus readers where
      overlapping spans were implicitly or explicitly forbidden but still
      being used
    ChaseDuncan committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    786459c View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. Addressing CI failures

    - Added another ctor to TokenLabelView which has a parameter
      for specifying whether or not to allow overlapping spans
    - Changed the TokenLabelView ctor which is used in StanfordTrueCaseHandler
      since it was clear that overlapping spans are desired
    ChaseDuncan committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    4c33f4f View commit details
    Browse the repository at this point in the history