Add isEnabledPublisher to UIButton #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 70.94% 70.56% -0.38%
==========================================
Files 28 28
Lines 561 564 +3
==========================================
Hits 398 398
- Misses 163 166 +3
Continue to review full report at Codecov.
|
freak4pc
reviewed
Feb 8, 2021
There was a problem hiding this comment.
Thank you @darko55555 !
Great addition, and the code looks good -
But, isEnabled is on UIControl, so sounds like there's an opportunity to have it for all UIControls.
Mind moving it to an appropriate extension and add a quick test for it in our test suite?
Thank you :)
freak4pc
requested changes
May 30, 2021
| @@ -16,5 +16,10 @@ public extension UIButton { | |||
| var tapPublisher: AnyPublisher<Void, Never> { | |||
| controlEventPublisher(for: .touchUpInside) | |||
| } | |||
|
|
|||
| var isEnabledPublisher: AnyPublisher<Bool, Never> { | |||
There was a problem hiding this comment.
Might make more sense for UIControl as a whole
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added isEnabled publisher to UIButton
Example of usage, assign to isEnabledPublisher for form validation.