CGS small update #2984
Open
CGS small update #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed DrawFilledEllipse function - added GetPixels function (gets a rectangle of pixels from the canvas and stores them into a bitmap) - added image resize functions
zarlo
reviewed
Mar 9, 2024
quajak
reviewed
Mar 9, 2024
| /// <param name="NewW">the new width of the bitmap</param> | ||
| /// <param name="NewH">the new height of the bitmap</param> | ||
| /// <returns>resized image</returns> | ||
| public static Bitmap Resize(Bitmap image, uint NewW, uint NewH) |
There was a problem hiding this comment.
Please rename NewW to newWidth and NewH to newHeight
Co-authored-by: Quajak <[email protected]>
Co-authored-by: Quajak <[email protected]>
Co-authored-by: Quajak <[email protected]>
|
@quajak all the commit requests have been accepted, also about the the getpixels function, i have moved it to the bitmap class. |
quajak
requested changes
Mar 10, 2024
|
@quajak Done, i have fixed any remaning changes. about the packages.lock thing.... i don't know how to revert it. could you tell me |
quajak
requested changes
Mar 15, 2024
| /// <returns>Bitmap</returns> | ||
| public static Bitmap FromCanvasRegion(Canvas canvas, int X, int Y, ushort W, ushort H) | ||
| { | ||
|
|
There was a problem hiding this comment.
Please fix the additional new lines and tabbing of the function
|
Bruh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for all the ghost additions and delitions but my github went crazy