Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make permission fixing optional (but default) #856

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

siliconfeces
Copy link
Contributor

This PR makes it possible to skip most of the chmod/chown fuckery going on when starting the docker version. This can make startup way faster if the content is accessed through NFS. I didn't quite figure out where to document it so I didn't. Permissions is still fixed for redis etc, this ONLY affects the content directory,

The default action is to use the previous behavior.

tl;dr, -e LRR_AUTOFIX_PERMISSIONS=0 makes startup go wroom wroom.

@Difegue
Copy link
Owner

Difegue commented Oct 7, 2023

Sure, looks good to me.

Environment variables are documented here https://sugoi.gitbook.io/lanraragi/v/dev/extending-lanraragi/architecture#specific-environment-variables-you-can-apply-to-change-lrr-behavior , although since that one is Docker-specific it's a bit different..
Maybe it should go in the Docker section instead?

@Difegue
Copy link
Owner

Difegue commented Oct 7, 2023

Not a super big deal tho so I guess I can merge this as-is. Thanks!

@Difegue Difegue merged commit 0397d25 into Difegue:dev Oct 7, 2023
1 check passed
@siliconfeces siliconfeces deleted the optional_chmod_fuckery branch October 8, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants