-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space charge Mayes IPAC2018 benchmark #429
base: development
Are you sure you want to change the base?
Conversation
- Modified the initial beam size in the IOTA lens benchmark example. - Added 2 benchmarks of 3D space charge for initial testing. - Add documentation for 2 benchmarks with space charge. - Add a benchmark example with space charge and periodic s-dependent focusing. - Added an s-dependent example using a Kurth beam without space charge. - Modified tolerance for IOTA lens benchmark example. Reduced tolerance to account for smaller initial beam size and improved preservation of invariants of motion. - Modified tolerances of space charge examples to allow CI tests to pass when space charge is not active. - Modified tolerance for space charge examples. These should fail unless space charge is turned on.
Selected numerical values for amr.n_cell, lattice.nslice, and geometry.prob_relative.
Not part of this PR
for more information, see https://pre-commit.ci
Removed file with incorrect suffix.
for more information, see https://pre-commit.ci
looks correct up to a unit conversion factor
for more information, see https://pre-commit.ci
Could the plot(s) be created and checked in, or at least put in docs somewhere? |
Expose the numeric parameters of the multi-grid solver that we currently use for space charge calculations.
@ChristopherMayes Thank you for your comment. Yes, absolutely. We still finalize a few space charge benchmarks for HB 2023 right now and this is one of them. As stated in your IPAC2018 paper, the non-IGF method starts to fail for large aspect ratios (w/o pushing resolution much further up). We added a preview to the PR description. We will clean this PR up further once final, e.g., replacing the data files from the analytical solution with results calculated on the fly. Yes, on the plots, too. The docs will get a readme file for the new case and we will include the plot, similar to https://impactx.readthedocs.io/en/latest/usage/examples/fodo/README.html |
Update "energy" -> "kin_energy"
Update kin_energy value.
Update sim.prob_relative syntax.
Update sim.prob_relative syntax.
Comment unused parameters.
del.sim -> sim.finalize()
for more information, see https://pre-commit.ci
Add access to required field data files.
Correct path.
Correct destination of copy.
Comment field test (debug).
for more information, see https://pre-commit.ci
Use large tolerance for now.
for more information, see https://pre-commit.ci
Use large tolerance for now.
for more information, see https://pre-commit.ci
Remove unnecessary plot lines (use plot_expanding_ipac2018.py instead).
for more information, see https://pre-commit.ci
Turn on second test.
Comment call to Ey for testing.
Correct Ey -> Ez
nGrowVect -> n_grow_vect
Turn off analysis for field plot test.
for more information, see https://pre-commit.ci
This PR refers to:
C. E. Mayes, R. D. Ryne, and D. C. Sagan, "3D Space Charge in BMAD," in proc. IPAC2018,
DOI:10.18429/JACoW-IPAC2018-THPAK085
This is a replacement for PR #257
Closes @ChristopherMayes' #256.
Added the expanding Gaussian beam test and plot script corresponding to phase space shown in Fig. 4.