fix: adds support for changing orientations #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
BottomSheet
usesDimensions
API in order to calculate the default max height. However, usingDimensions
is discouraged as it does not reflect changes (see https://reactnative.dev/docs/dimensions), which is necessary if users change from portrait to landscape and vice versa. This PR replacesDimensions
withuseWindowDimensions
inBottomSheet
, so that changes in orientation can be handled to calculate the default max height.Fixes # (issue)
Type of Change
How Has This Been Tested?
Use BottomSheet and change orientation of device while app is running.
Checklist: (Feel free to delete this section upon completion)