Fix compiler warnings on VS2019 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmintram
commented
May 9, 2021
| @@ -977,13 +977,14 @@ class SQCompiler | |||
| break; | |||
| } | |||
|
|
|||
| SQObject id; | |||
| SQObject id = {}; | |||
jamesmintram
commented
May 9, 2021
| SQObject constant; | ||
|
|
||
| switch(_token) { | ||
| case TK_IDENTIFIER: id = _fs->CreateString(_lex._svalue); break; | ||
| case TK_THIS: id = _fs->CreateString(_SC("this"),4); break; | ||
| case TK_CONSTRUCTOR: id = _fs->CreateString(_SC("constructor"),11); break; | ||
| default: Error("Unhandled token type %d", _token); break; |
jamesmintram
commented
May 9, 2021
| #pragma warning(disable: 4611) // interaction between '_setjmp' and C++ object destruction is non-portable | ||
| #endif | ||
|
|
||
| #if defined(_MSC_VER) |
There was a problem hiding this comment.
Enable platform/compiler specific handling for unreachable code.
The _MSC_VER condition could be changed to a user defined flag, allowing
users to choose the behaviour of UNREACHABLE.
Happy to accept feedback.
VasiliyRyabtsev
force-pushed
the
master
branch
from
709c111
to
aa4d2cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of compiler warnings generated by VS2019
Only tested these changes on VS2019.