-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impact of third-party render blocking scripts #33
base: main
Are you sure you want to change the base?
Impact of third-party render blocking scripts #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Left a few comments below. Overall this looks good, but I'd like for someone from the HTTP Archive team with more experience in those queries to have a look too.
Can you please provide a reference in the PR description for what the query is based on (https://almanac.httparchive.org/en/2022/javascript#requests, or more specifically https://github.com/HTTPArchive/almanac.httparchive.org/blob/main/sql/2022/javascript/requests_by_3p.sql)?
Regardless of whether the query is entirely correct like this or not, I just ran it (consumes 3 TB, so not too bad) and posted the results on the PR description.
date = '2022-06-01' | ||
AND type = 'script' | ||
AND JSON_EXTRACT(pages.payload, '$._detected_apps.WordPress') IS NOT NULL | ||
AND CAST(JSON_EXTRACT( pages.payload, '$._renderBlockingJS') AS INT64) > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see now, here we use pages
too, and this part wouldn't be in the technologies
table. So maybe you're right and we need to keep using that table. What is the check here for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per Percent of pages using render-blocking JavaScript, We can parse the pages.payload
to get render blocking script counts.
# limitations under the License. | ||
|
||
# See query results here: https://github.com/GoogleChromeLabs/wpp-research/pull/33 | ||
SELECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main goal here is to study render-blocking third-party scripts.
However, the sub-query i.e (httparchive.almanac.third_parties)
, brings up 1p and 3p scripts, both render-blocking and non-render blocking.
We are making this study on a site where at least one script is render-blocking, but we can't say through this query if the third-party script is part of the render-blocking script.
# limitations under the License. | ||
|
||
# See query results here: https://github.com/GoogleChromeLabs/wpp-research/pull/33 | ||
SELECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 I am convinced this query will return the distribution of all the third parties and first parties (both render blocking and non-render blocking) for a site with at least one render-blocking script.
This won't return the distribution of render-blocking third-party and render-blocking first-party scripts.
Please find my explanation and example in this comment
I am finding it hard to explain in this PR.
cc: @felixarntz
Fixes #30
Query results
Based on June 2022 dataset.
For the query use below references: