-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to release hybridsim nightly. #242
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you wrap nightly_release_utils
in a folder of multipod
or have a prefix of the folder? Also please feel free to add owners to this folder here. So any changes will be needed approval from your team.
.github/workflows/nightly_release_utils/build_and_upload_images.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this PR. This workflow has (as near as I can tell) no relation to the content in this repository. Are you building this image to consume in a test workflow down the line? cc @jonb377 who was looking into this
What's the TPU self hosted runner for? I don't see any part of this workflow that actually utilizes a TPU device.
IMO you would be much better off creating a scheduled Cloud Build workflow. This is more in-line with internal guidance (search "fewer build services" internally). See https://cloud.google.com/build/docs/schedule-builds and https://cloud.google.com/build/docs/build-push-docker-image for instructions to get set up with GCB. GCB also makes permission management easier -- I assume you had to generate a temporary service account token to set up GHA, and you'd have to periodically rotate that token.
662cd9b
to
4425dbb
Compare
Done. |
4425dbb
to
4b0adc0
Compare
Description
Tests
Please describe the tests that you ran on Cloud VM to verify changes.
Instruction and/or command lines to reproduce your tests: ...
List links for your tests (use go/shortn-gen for any internal link): ...
Tested in workflow
https://screenshot.googleplex.com/9fUqW5HDzUDBPti
Checklist
Before submitting this PR, please make sure (put X in square brackets):