Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mixtral BS #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Mixtral BS #345

wants to merge 1 commit into from

Conversation

yeandy
Copy link
Collaborator

@yeandy yeandy commented Jul 2, 2024

Description

Update Mixtral batch size since 256 taking very long time.

Tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@vipannalla
Copy link
Collaborator

Higher batch_size is supposed to be faster given the same number of samples. How much slower is the current run? and how much faster is the run with batch_size = 128?

@yeandy
Copy link
Collaborator Author

yeandy commented Jul 2, 2024

It takes about ~12 min for 128 batch on bf16. Haven't tested for int8.

Not sure why it's hitting timeout at 3 hours for int8 version. Let me try running int8 at 128.

@@ -457,7 +457,7 @@
"quant_mode": W_INT8_KV_INT8,
"quantization": "int8",
"quantize_kvcache": "true",
"per_device_batch_size": 258,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait! we have already quantized for inference on MaxText?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Collaborator

@RissyRan RissyRan Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which implementation is this one? I don't think I enabled quantization for both matmul or megablox yet (I mean MoE block, other blocks are enabled). Or other implementation we are talking about here?

@vipannalla
Copy link
Collaborator

I think this configuration is using the old for for loop implementation, which Ranran cleaned up recently. I don't think the current code support quantization right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants