-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: asks user for OTP in CLI #636
base: master
Are you sure you want to change the base?
Conversation
I'll look into the build failure, seems like my local formatting is off. |
Yeah, requires blackd format |
Fixed the formatting. |
I’ve feared this is a possible intermediate screen. I’ll see if I can reproduce this with my second account. the question remains though: what should the bot choose? |
@timbru31 if the solution proposed in this PR is to allow the user to input an OTP value from the CLI, then I think its safe to assume that the user should be using a 2FA app which can generate an OTP. The OTP from the 2FA app should be input into the console for the bot to use. I think adding support for the other options is unnecessary and more nice-to-have than useful. I captured screenshots of the elements that need to be selected by the bot |
Thanks! I’ll integrate this intermediate screen |
Cool, ill wait for the PR update and try it out |
@Spareo can you give my new commits a second try? |
feat: sends a notification if OTP input is required feat: tries to set the "Do not ask for OTP on this device" flag This closes Hari-Nagarajan#617
@timbru31 just tried it out, worked great! Worked in headless as well. Thank you! |
Nice. Marking as ready then 👍👊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So one concern I have is that if the OTP is entered in the terminal, people are going to get confused about why it doesn't continue if they enter in their OTP in the browser and it doesn't continue.
Should we enable this only if running headless? Thoughts?
This might be a change in the current flow, but the e-mail and password are entered in the CLI, too. |
feat: sends a notification if OTP input is required
feat: tries to set the "Do not ask for OTP on this device" flag
This closes #617
This is the notification the bot sends on OTP titles: