Allow the default Android app API version to be overwritten by environment variable. #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android app API version is hardcoded to version 23.
Which forces people to install the API version 23 when they try to run any kind of rake task,
for example
rake android:device
or evenrake android:spec
will result in:Allowing users to optionally overwrite this hardcoded value with an environment variable
ANDROID_APP_API_VERSION
provides a bit more flexibility.Otherwise, it might be annoying because what if for example a user wants to set up and use API version 28 only without having to deal with version 23.
TL;DR
The optional
ANDROID_APP_API_VERSION
environment variable in this PR does not change/break the current gem behavior in any way.And it may not be a long term solution but It does allow for some clarity and flexibility when it comes to picking the Android API version for a project.
Please accept.
Cheers,
Khalil