This repository has been archived by the owner on Jan 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Upgrade kitura #91
Open
sanjeevghimire
wants to merge
7
commits into
master
Choose a base branch
from
upgrade-kitura
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade kitura #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sanjeevghimire
commented
May 13, 2019
- upgrade kitura
- new CFC checklist items and model
Daaaaaaaang this pull request is large |
+27,444 −318 NBD |
I think its because of the upgrade and changes are there on both iOS and Server. |
I promise to check this by the end of the week. On a side thread, I absolutely will help you get this submitted to the app store tomorrow, but let's take a second look at this and see what we can cull off. |
Both app and server are thoroughly tested. There are few things I have
removed which I have enhanced a bit. We can go over that tomorrow, test it
out one more time and push.
On Mon, May 13, 2019 at 7:13 PM David Okun ***@***.***> wrote:
I promise to check this by the end of the week. On a side thread, I
absolutely will help you get this submitted to the app store tomorrow, but
let's take a second look at this and see what we can cull off.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#91?email_source=notifications&email_token=AAM5RWZFN2JEQCQ572U7PDTPVH7Y5A5CNFSM4HMTFUA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVJ4YTY#issuecomment-492031055>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM5RWZ5Z7NKONZN7BBOBB3PVH7Y5ANCNFSM4HMTFUAQ>
.
--
सन्जीब िघमिरे
(Sanjeev Ghimire)
|
…n't handle A12 chip effectively.
nice |
stevemar
approved these changes
May 16, 2019
…ed push notifications creds, fixed bug when starting new game
JFYI we have released v1.2 of this app to the app store 🎉 Neil found a bug that I've already fixed with a commit here, and I'm testing to see if there's anything else I can find wrong with it. The bug is not a showstopper, so this version being live is ok, but I intend to review this PR entirely today, and that way 1.2.1 can be released from the master branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.