Skip to content
This repository has been archived by the owner on Jan 22, 2021. It is now read-only.

Upgrade kitura #91

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Upgrade kitura #91

wants to merge 7 commits into from

Conversation

sanjeevghimire
Copy link
Contributor

  • upgrade kitura
  • new CFC checklist items and model

@dokun1
Copy link
Contributor

dokun1 commented May 13, 2019

Daaaaaaaang this pull request is large

@dokun1 dokun1 self-requested a review May 13, 2019 20:41
@stevemar
Copy link
Contributor

+27,444 −318 NBD

@sanjeevghimire
Copy link
Contributor Author

I think its because of the upgrade and changes are there on both iOS and Server.

@dokun1
Copy link
Contributor

dokun1 commented May 14, 2019

I promise to check this by the end of the week. On a side thread, I absolutely will help you get this submitted to the app store tomorrow, but let's take a second look at this and see what we can cull off.

@sanjeevghimire
Copy link
Contributor Author

sanjeevghimire commented May 14, 2019 via email

@stevemar
Copy link
Contributor

nice

@dokun1
Copy link
Contributor

dokun1 commented May 20, 2019

JFYI we have released v1.2 of this app to the app store 🎉

Neil found a bug that I've already fixed with a commit here, and I'm testing to see if there's anything else I can find wrong with it. The bug is not a showstopper, so this version being live is ok, but I intend to review this PR entirely today, and that way 1.2.1 can be released from the master branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants