Clean warnings in context when transforming multiple files #665
Conversation
|
Hi @jschavesr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| ) | ||
| # Each module will generate 2 warnings, so we should get 6 warnings in total | ||
| self.assertIn( | ||
| "- 6 warnings were generated.", |
There was a problem hiding this comment.
I take it 6 because there are 2 per file - would it have been 2 + 4 + 6 = 12 prior to this fix?
|
Running CI, I'll merge if it comes back clean |
| "libcst.tool", | ||
| "codemod", | ||
| "convert_format_to_fstring.ConvertFormatStringCommand", | ||
| p, |
There was a problem hiding this comment.
Looks like we're getting test failures on Python 3.7 + Windows.
I think the problem may be here - the other test in this module calls str on the Path before passing it to subprocess.run.
|
@jschavesr Do you plan on completing this? Looks very useful, without this change it's impossible to use warnings in multiprocessing context. They all get duplicated and assigned to wrong files. If you are no longer interested, I could take over and submit an updated copy of this PR. Thanks! |
Summary
Using libCST cli tool allows to run a codemod over files inside a folder recursively. Context warning messages were not being cleaned between files, so warnings from one files could be passed to other files in the context. Because of that warnings were being shown wrongly in the summary and the total number of warnings was wrong as well.
Test Plan
python3 -m unittest libcst.codemod.tests.test_codemod_cli