Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GraphQL .NET Version 5 #24

Merged
merged 8 commits into from
Jul 20, 2022

Conversation

ganhammar
Copy link
Contributor

@ganhammar ganhammar commented Jun 12, 2022

With this pull request the project supports GraphQL .NET version 5.

Also dropped the support of .NET core version 2.1 since it's reached end-of-life.

EDIT:
Also added fix for issue #14

I added a GitHub action to potentially replace Azure DevOps, up to you, you can see the result of the pipeline here: https://github.com/ganhammar/graphql-dotnet-upload/actions

@ganhammar ganhammar changed the title Support graphql 5 Support GraphQL .NET Version 5 Jun 12, 2022
@ganhammar
Copy link
Contributor Author

@JannikLassahn I think the pipeline needs update for the build to pass, tests pass locally. I could update the definition if you gave me access.

Copy link
Owner

@JannikLassahn JannikLassahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I really like all these changes, especially the simplifications around JSON deserialization. Moving to GitHub Actions is also quite nice.
Thanks for your work!

src/GraphQL.Upload.AspNetCore/UploadGraphType.cs Outdated Show resolved Hide resolved
@JannikLassahn JannikLassahn merged commit 1c53cfc into JannikLassahn:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants