Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve offset axes in @progress with comprehension #605

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yha
Copy link
Contributor

@yha yha commented Sep 1, 2020

I'm guessing this fix is probably needed at ProgressLogging.jl as well, but it's not used by Juno yet.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #605 into master will decrease coverage by 0.63%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   42.85%   42.22%   -0.64%     
==========================================
  Files           7        7              
  Lines         133      135       +2     
==========================================
  Hits           57       57              
- Misses         76       78       +2     
Flag Coverage Δ
#unittests 42.22% <25.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/progress.jl 53.12% <25.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39191e...dffe13a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant