Fixes #37923 - Set HTTP proxy as default after creating #11183
Conversation
|
@stejskalleos is this ready to be pulled out of draft state? |
|
@chris1984 not yet, I need to update Jira tickets first and check if I haven't forgot something |
stejskalleos
force-pushed
the
ls/default_http
branch
from
a288ef2
to
3102a6f
Compare
|
@chris1984 @ShimShtein ready for review, together with theforeman/foreman#10372 |
app/controllers/katello/concerns/api/v2/http_proxies_controller_extensions.rb
Outdated
Show resolved
Hide resolved
stejskalleos
force-pushed
the
ls/default_http
branch
from
3102a6f
to
e320acd
Compare
|
@ofedoren updated |
app/views/overrides/http_proxies/_update_setting_input.html.erb
Outdated
Show resolved
Hide resolved
app/controllers/katello/concerns/api/v2/http_proxies_controller_extensions.rb
Outdated
Show resolved
Hide resolved
| id: 'http_proxy_default_content' %> | ||
| Set this proxy as the default for content, updating the 'Default HTTP Proxy' setting. | ||
| </div> |
There was a problem hiding this comment.
When we create a http proxy with default_content_proxy set to true with UI, it gets created successfully and setting is updated, but when we click on created proxy on edit page we don't see the value set for default_content_proxy, so I feel it would be better to include it on edit page too
There was a problem hiding this comment.
And, If we decide to add it to the edit page, will it be possible to change it or will it remain grayed?
There was a problem hiding this comment.
It's tied to a Setting, so if it were included on the edit page it would have to be disabled. It would just be an indicator of whether this current HTTP proxy is set as the default.
|
I agree with the suggestions by Ian and Gaurav above. |
stejskalleos
force-pushed
the
ls/default_http
branch
from
e320acd
to
ea82486
Compare
|
@ianballou @Gauravtalreja1 texts updated |
|
Are other parties all good with the changes? @Lennonka and @Gauravtalreja1 ? |
|
LGTM |
What are the changes introduced in this pull request?
An option for making HTTP proxy the default content proxy after creation.
Considerations taken when implementing this change?
https://issues.redhat.com/browse/SAT-28860
What are the testing steps for this pull request?
default content = truecontent_default_http_proxysetting