Sync translation infrastructure from foreman_plugin_template #11193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies the Makefile from foreman_plugin_template to resolve an issue with the time stamp handling and pulling in new translations that made it past 50%. It also ignores action_names.rb since that's now considered a best practice. Generated files do not belong in git.
ekohl
commented
Oct 29, 2024
There was a problem hiding this comment.
@ianballou in the past we looked into this. Would you mind taking a look?
cc @sambible @chris1984 for visibility. We should merge this before we do the final pull with translations. Especially the .po.time_stamp handling previously caused issues where some languages weren't updated and thus missed translations.
|
|
||
| %.mo: %.po | ||
| mkdir -p $(shell dirname $@)/LC_MESSAGES | ||
| msgfmt -o $(shell dirname $@)/LC_MESSAGES/$(MOFILE) $< | ||
| touch $(shell dirname $@)/LC_MESSAGES/$(MOFILE) |
There was a problem hiding this comment.
I have noticed that msgfmt doesn't always update the timestamp, if there are no changes. Now I'm unsure if this is still an issue after the time_stamp handling is fixed.
| commit-translation-files: $(POFILES) | ||
| git add $(POFILES) $(POTFILE) $(ACTIONFILE) ../app/assets/javascripts/katello/locale | ||
| mo-files: $(MOFILES) | ||
| git add $(POFILES) $(POTFILE) $(JSFILES) ../locale/*/LC_MESSAGES |
There was a problem hiding this comment.
The ../locale/*/LC_MESSAGES part adds the .mo files and I think we ignore those here.
|
We'll get this reviewed soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
This copies the Makefile from foreman_plugin_template to resolve an issue with the time stamp handling and pulling in new translations that made it past 50%. See theforeman/foreman_plugin_template#65 & theforeman/foreman_plugin_template#57 for that.
It also ignores action_names.rb since that's now considered a best practice. Generated files do not belong in git. See theforeman/foreman_plugin_template#64.
Considerations taken when implementing this change?
It's now a draft since I see some changes and we should investigate those. A PR helps to centralize that discussion.
What are the testing steps for this pull request?
Update translations per standard practice and see that everything is properly updated.