-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37958 - Add "Sync Dependencies" option to Ansible collection repositories #11195
Fixes #37958 - Add "Sync Dependencies" option to Ansible collection repositories #11195
Conversation
Code looks good. Would you be able to provide an example live repo to test this with? We'll want to add some automation around testing this. The failing tests on this are VCR tests. Atix folks have previously recorded VCRs but if you face any issues, let me know and I can help with that.. |
e3d8c1a
to
511e6d1
Compare
The VCRs should be good now, but I am struggling a bit with the test. |
There are some helper methods you could use here in the sync test:
The data will need to be set up in fixture here:
I imagine something like for the test:
|
511e6d1
to
f6fd4f0
Compare
Thanks for your help! Test is added. |
- 860cc24bec6e4aa8ad51bb36e23a67de | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VCRs seem to have merge conflicts of some sort..What you can do is restore these files, rebase and then re-record the sync test..
34440d9
to
466e685
Compare
466e685
to
5537e6a
Compare
@sjha4 ready for review again :-) |
5537e6a
to
433876a
Compare
Tested latest changes, LGTM! |
Redmine issue
This PR adds a new option, "Sync dependencies", to Ansible collection repositories.
When enabled (default), Pulp will sync the collections given in the requirements file and their dependencies.
When disabled, Pulp will only sync the collections, without their dependencies.
On the backend side, this is done by passing
sync_dependencies
to pulp_ansible.I decided to keep track of where this setting is enabled at the root repository level, should we ever want to extend this functionality past Ansible collections.