Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38011 - Apply environment filter for content override #11218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nadjaheitmann
Copy link
Contributor

@nadjaheitmann nadjaheitmann commented Nov 14, 2024

What are the changes introduced in this pull request?

When overriding the status on the repository sets page, the state was internally changed. However, it did not show but instead an empty error toast was shown.

Considerations taken when implementing this change?

In structured-apt feature, we use a specific environment to show the correct repo entry, otherwise we would show multiple entries for one repository. We need to apply this environment filter when the override is evaluated.

What are the testing steps for this pull request?

  1. Enable structured-apt feature
  2. Create ActivationKey with deb-repositories
  3. Roll out a Debian host
  4. Go to Host --> HostDetails --> Content --> Repository Sets
  5. Try to change any override setting in the repo's kebab menu

@nadjaheitmann nadjaheitmann force-pushed the 38011_empty_error_toast branch 5 times, most recently from 567e878 to 3bcc7e6 Compare November 20, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant