Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38047 - Do not tranlsate links in toasts #11238

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

MariaAga
Copy link
Contributor

What are the changes introduced in this pull request?

Links are no longer translated for toast notifications

Considerations taken when implementing this change?

Searched for translate\(.*/ in the code, and removed the translation around links

What are the testing steps for this pull request?

have mark for translations on, sync a product and click the link, the link will work as its not surrounded by X

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 👍🏼

@sjha4 sjha4 merged commit 58f2eda into Katello:master Nov 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants