Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TurboSnap for Chromatic #1917

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented Nov 26, 2024

Summary:

EDIT: We cannot enable TurboSnap for Perseus because we already use onlyStoryFiles (which restricts the set of stories to run, but is incompatible with the onlyChanged setting.

As a result of ☝️, this PR has been updated to document that onlyStoryFiles prevents use of onlyChanged.

This PR enables TurboSnap for the Perseus repo. TurboSnap is already enabled or the Perseus project on Chromatic.com, but we noticed it wasn't enabled for the Github Action that runs it.

Issue: "none"

Test plan:

Watch the actions on this build. We might have to land this and monitor future builds to see it working as I'm not sure if there'll be a proper baseline for TurboSnap to work off of.

@jeremywiebe jeremywiebe self-assigned this Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (f87369d) and published it to npm. You
can install it using the tag PR1917.

Example:

yarn add @khanacademy/perseus@PR1917

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1917

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Size Change: 0 B

Total Size: 1.29 MB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 697 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 421 kB
packages/perseus/dist/es/strings.js 3.68 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@jeremywiebe jeremywiebe marked this pull request as ready for review November 26, 2024 19:07
@khan-actions-bot khan-actions-bot requested a review from a team November 26, 2024 19:07
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .github/workflows/storybook.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants