TEST: Copyright pre-commit #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @s-boardman - I think you might be interested in this. |
That's absurdly clever Carwyn! |
copyright_check
Outdated
| echo "Adding missing Copyright to '${filepath}'" | ||
| tmp_file="${filepath}.tmp" | ||
| rm -f ${tmp_file} 2&> /dev/null | ||
| touch ${tmp_file} |
There was a problem hiding this comment.
You can replace the "rm" and "touch" lines with a single line:
echo -n > ${tmp_file}
copyright_check
Outdated
| echo -e ${copyright_header} >> ${tmp_file} | ||
| tail -n +2 ${filepath} >> ${tmp_file} | ||
| else | ||
| echo -e ${copyright_header} >> ${tmp_file} |
There was a problem hiding this comment.
If you change this to > rather than >> you can do away with removing the ${tmp_file} above because then the if and the else will both create the file afresh anyway.
mo-robert-purvis
previously approved these changes
Jun 19, 2024
cpelley
force-pushed
the
COPYRIGHT_PRECOMMIT
branch
from
de34c34
to
b542015
Compare
|
Thanks @mo-robert-purvis Tidied up based on feedback. Additionally improved by adding:
|
SamGriffithsMO
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added copyright pre-commit check.
Copyright check acts to check for the presence of and verify the validity of the copyright header of python files. Additionally, the role of the script is to automatically add this copyright notice (thus eliminating the need to deal with copyright headers yourself).
Issues
Note
Just to raise awareness as the first dagrunner PR under review - since this branch makes changes that impact the reference documentation, an auto reference documentation build commit will be pushed accordingly thanks to the dagrunner action workflow.