Skip to content

Commit

Permalink
DrawPathTool: Fix crash introduced by object highlighting
Browse files Browse the repository at this point in the history
Closing a path with Enter key or aborting the drawing procedure with
Escape causes Mapper crash on stale renerables further down the drawing.
The simple "following = false" is no longer enough to finish object
following. We need to remove the highlight renderables whish is done in
finishFollowing().
  • Loading branch information
lpechacek committed Feb 4, 2024
1 parent 0412a1f commit 06af0c3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/tools/draw_path_tool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ void DrawPathTool::finishDrawing()
}

dragging = false;
following = false;
finishFollowing();
setEditingInProgress(false);
if (!ctrl_pressed)
angle_helper->setActive(false);
Expand All @@ -932,7 +932,7 @@ void DrawPathTool::finishDrawing()
void DrawPathTool::abortDrawing()
{
dragging = false;
following = false;
finishFollowing();
setEditingInProgress(false);
if (!ctrl_pressed)
angle_helper->setActive(false);
Expand Down

0 comments on commit 06af0c3

Please sign in to comment.