-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapEditorController: Show details for map part operations #2110
base: master
Are you sure you want to change the base?
Conversation
When merging or removing a map part the user is not informed about the number of affected objects. This easy change tells the user how many objects are subject of merging or removing a map part.
I like this, considering the whole. As for the details, I would prefer not to be questioned about removing an empty map part. |
@pkturner: Indeed it's an option to remove the popup window if empty map parts shall be removed or merged. |
Given that the map part operations can be undone, I'm all fine with skipping the confirmation on empty parts. Code-wise, I'm going to review the second patch soon. I've got a remark right away though. The variable holding the number of map parts ( |
I agree and will change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The comment about the num_objects
change is more a nitpicking than a code issue. Take it and re-rest the change if you like the change, or leave it as is. Thanks!
If the map part to be removed or merged is empty, it's an option to avoid asking the user before removing the empty map part as no objects are affected. This commit removes the popup window in case of empty map parts.
When merging or removing a map part the user is not informed about the number of affected objects.
This easy change tells the user how many objects are subject of merging or removing a map part.