Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OcdFileImport: Revise path coord processing #2224

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

OcdFileImport: Revise path coord processing #2224

wants to merge 7 commits into from

Commits on Aug 3, 2024

  1. OcdFileImport: Factor-in setPointFlags 

    Preparation for improved state handling and bug fixes.
No observable change of behavior intented.
    @dg0yt
    dg0yt committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    7144415 View commit details
    Browse the repository at this point in the history

  2. OcdFileImport: Factor-in setPathHolePoint 

    Preparation for improved state handling and bug fixes.
No observable change of behavior intented.
    @dg0yt
    dg0yt committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    82e8164 View commit details
    Browse the repository at this point in the history

  3. OcdFileImport: Simplify fillPathCoords

    @dg0yt
    dg0yt committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    aa63060 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. OcdFileImport: Use counter to ignore hole points

    @dg0yt
    dg0yt committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    f33b1ef View commit details
    Browse the repository at this point in the history

  2. OcdFileImport: Process coords with std::for_each 

    ... and use iterators for input and output.

Preparation for improved state handling and bug fixes:
No tight coupling of input position and output position.
No observable change of behavior intented.
    @dg0yt
    dg0yt committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    164a7e2 View commit details
    Browse the repository at this point in the history

  3. FileFormatTest: Disallow adjacent hole points

    @dg0yt
    dg0yt committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    ef404a2 View commit details
    Browse the repository at this point in the history

  4. OcdFileImport: Drop hole points before hole points 

    .#
    @dg0yt
    dg0yt committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    dc2e929 View commit details
    Browse the repository at this point in the history