-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local contribution guide #69
base: main
Are you sure you want to change the base?
Conversation
@Cli4d I took a brief look at this draft, and it seems quite good already! What would you like to tackle before opening it for review? 🙂 |
I may have been overcomplicating it. Let me open it for review. We can add things based on feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Cli4d!
The content is great, but the proposed location does not seem very appropriate to me: it splits the current document that, admittedly, is more a reference, right in the middle.
I would suggest to create a new, dedicated page called “contributing terms” with your content, and rename the existing one to “Declarations reference” or move it into a new group called “Reference” with a page called “Declaration”, just like there is currently a group called “Guidelines” with a page called “Targeting” 🙂
Let us know if you need any help in this!
This is to stick with the business terms Co-authored-by: Matti Schneider <[email protected]>
Made some minor edits for better readability Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Some grammar improvement for better readability Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Please let me know when this PR is ready for review by using the “request review” feature 🙂 |
This is to stick with the business terms Co-authored-by: Matti Schneider <[email protected]>
Made some minor edits for better readability Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Some grammar improvement for better readability Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
…sArchive/docs into add-local-contrib-guide
✅ Deploy Preview for open-terms-archive-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Cli4d and @clementbiron!
I feel that there is still a tiny bit of work necessary before the value provided by this changeset in providing a simpler approach to contribution goes beyond the costs it has in splitting and having potentially redundant content.
Based on the live preview, I feel that this branch is not up to date. @clementbiron could you please make sure that the latest changes are integrated, probably through an upstream merge? I for example do not see the “Creating a collection” page.
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Just realized how important this documentation is important as I was trying to review the contributions to Kenya Declarations I see there are some tests that failed again. Not sure why, I believe I had fixed everything before ending the 6-month program. However, I'll try to find and fix the broken links |
I have created a simple draft that we can build upon to act as the local contribution guide. I've added towards the end of the
contributing terms
page since the information that comes before is importantResolves OpenTermsArchive/template-declarations#32