[GUI] Deterministic Masternode #2804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decoupling the RPC server errors from the function.
And use the `PROTOCOL_VERSION` instead of the `CLIENT_VERSION`. Which should had never been used there as the serialization of inputs/spend_notes cannot be modified changing the `CLIENT_VERSION`, it's a hard-fork that needs a protocol bump.
Same validation is performed inside TryATMP.
…the network. The transaction inputs are always from the wallet.
And remove duplicated available inputs validation. The code will perform the same check few lines after the signature inside ATMP.
Differentiating deterministic from legacy masternodes
…created locally). Only useful when the owner generates the operator key, so the object can be securely stored inside the wallet.dat encrypted. A future work could create an encryptable db for this specific object.
…qual to the previous type
… not general std::exception.
Seems to only happen on linux.
co-authored with random-zebra
Liquid369
force-pushed
the
2023_DMN_GUI
branch
from
4304c69
to
fd66231
Compare
panleone
previously approved these changes
Feb 10, 2023
There was a problem hiding this comment.
tACK:
checked the git diff which is consistent with the old PR;
two tests did not pass but it must be a github bug since they passed locally on my pc;
tested GUI which is working fine for creation / killing / unbanning a DMN.
Let's get this merged to move on with v6.0
|
Yesterday I pushed some fixes for the RPC naming as we discussed @Fuzzbawls but I decided to revert it because so many other PRs would need to fix the same we will push it in a subsequent PR after we start getting these merged. |
Fix lint Fix CMake Remove GetMNCollateralCandidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored with @panleone
This PR is superseding both PRs #2751 and #2791
It contains the following fixes/improvements we've found during testing:
Prior PR had remnants of #2755