Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify class_num to num_classes #176

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

unify class_num to num_classes #176

wants to merge 4 commits into from

Conversation

TingquanGao
Copy link

No description provided.

@TingquanGao TingquanGao changed the title unify num_classes to class_num [WIP] unify num_classes to class_num Jun 27, 2023
GuoxiaWang
GuoxiaWang previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@GuoxiaWang GuoxiaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM， change num_classes to class_num unified.

@TingquanGao
Copy link
Author

看了下这样改影响太大，只修改model的接口比较好，我再改下。

@TingquanGao
Copy link
Author

这里的代码似乎没有用到，不确定直接修改是否会造成其他影响，因此暂未修改：

https://github.com/PaddlePaddle/PASSL/blob/main/tasks/ssl/mocov3/builder_moco.py#L19-L37C66

@TingquanGao TingquanGao changed the title [WIP] unify num_classes to class_num unify num_classes to class_num Jun 27, 2023
@TingquanGao
Copy link
Author

fix #175

@TingquanGao TingquanGao changed the title unify num_classes to class_num unify class_num to num_classes Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoxiaWang GuoxiaWang GuoxiaWang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingquanGao @GuoxiaWang