-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backward induction and beta =1 #172 #228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
===========================================
- Coverage 95.85% 56.83% -39.03%
===========================================
Files 25 25
Lines 1061 1786 +725
===========================================
- Hits 1017 1015 -2
- Misses 44 771 +727
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
@sglyon What is the status of issue #136 (documentation style)? Isn't it more efficient to start following the official guidance in the new code? |
Will you also add a test with (Define the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments.
Thanks. Fix them. |
Fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think this is ready to merge.
@sglyon Can I merge this PR? |
Looks great to me, thank you for following up. Sorry I forgot to merge this after it was approved |
This pull request is related with #172.
I try the followings.
backward_induction
method and explanation.beta = 1
for DiscreteDP`close #172.