Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stoppropagation #7102

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix stoppropagation #7102

merged 4 commits into from
Nov 27, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Nov 27, 2024

What is it?

  • Bug

Description

This fixes the implementation of stoppropagation:

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 87c85a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shairez shairez self-assigned this Nov 27, 2024
Copy link

pkg-pr-new bot commented Nov 27, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7102
npm i https://pkg.pr.new/@builder.io/qwik-city@7102
npm i https://pkg.pr.new/eslint-plugin-qwik@7102
npm i https://pkg.pr.new/create-qwik@7102

commit: 19adfd8

Copy link
Contributor

github-actions bot commented Nov 27, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 87c85a9

gioboa
gioboa previously approved these changes Nov 27, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@shairez shairez marked this pull request as ready for review November 27, 2024 14:02
@shairez shairez requested a review from a team as a code owner November 27, 2024 14:02
Copy link
Contributor

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👏
@shairez you rock

@shairez shairez merged commit 2ed63b7 into main Nov 27, 2024
20 checks passed
@shairez shairez deleted the pr-fix-stop-propagation branch November 27, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants