fix: proper error handling of AzurePublicIpv4Addresses (#4288)

Signed-off-by: Xiaoxue Wang <[email protected]>

insights/parsers/azure_instance.py

@@ -196,7 +196,12 @@ def parse_content(self, content):
 
         try:
             plan = json.loads(' '.join(content))
-            for pair in plan["loadbalancer"]["publicIpAddresses"]:
-                self.append(pair["frontendIpAddress"])
         except:
             raise ParseException("Unable to parse JSON")
+
+        for pair in plan.get("loadbalancer", {}).get("publicIpAddresses", {}):
+            if pair.get("frontendIpAddress"):
+                self.append(pair["frontendIpAddress"])
+
+        if len(self) == 0:
+            raise SkipComponent("No 'frontendIpAddress'.")

insights/tests/parsers/test_azure_instance.py

@@ -87,6 +87,26 @@
 curl: (28) connect() timed out!
 """.strip()
 AZURE_LB_ERR4 = "}}}"
+AZURE_LB_ERR5 = """
+{ "error": "No load balancer metadata is found. Please check if your VM is using any non-basic SKU load balancer and retry later." }
+""".strip()
+AZURE_LB_ERR6 = """
+{
+  "loadbalancer": {
+    "publicIpAddresses": [
+      {
+        "frontendIpAddress": "",
+        "privateIpAddress": "10.0.0.4"
+      },
+      {
+        "privateIpAddress": "10.0.0.4"
+      }
+    ],
+    "inboundRules": [],
+    "outboundRules": []
+  }
+}
+""".strip()
 
 
 # Test AzureInstanceID
@@ -213,5 +233,11 @@ def test_azure_public_ipv4():
     with pytest.raises(ParseException):
         AzurePublicIpv4Addresses(context_wrap(AZURE_LB_ERR4))
 
+    with pytest.raises(SkipComponent):
+        AzurePublicIpv4Addresses(context_wrap(AZURE_LB_ERR5))
+
+    with pytest.raises(SkipComponent):
+        AzurePublicIpv4Addresses(context_wrap(AZURE_LB_ERR6))
+
     azure = AzurePublicIpv4Addresses(context_wrap(AZURE_LB_1))
     assert azure[0] == "137.116.118.209"