Extract host (de)serialization #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new module app.serialization. Extracted all Host serialization and deserialization logic into that module. Used the existing paradigm from CanonicalFacts and Facts classes for the Host itself too. All the logic and behavior remained unchanged.
Glutexo
force-pushed
the
host_serialization_new_module
branch
from
b8d9e8b
to
e336edd
Compare
This was referenced Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new module app.serialization. Extracted all Host serialization and deserialization logic into that module. Used the existing paradigm from CanonicalFacts and Facts classes for the Host itself too. All the logic and behavior remained unchanged.
This is a part of the bigger picture of extracting the host import/export to a single place. See #323. The Host class name clash is not the nicest thing, but it’s valid as it’s in a different module. Still this is just a temporary state, since I plan to ditch the classes and rename the functions as one of the further steps.